wasi: skips fd_readdir until fixed upstream #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current fd_readdir test is invalid as it requires dot and dot-dot entries, which both aren't required by POSIX nor returned by go. Once this is addressed upstream, we can remove the skip. See WebAssembly/wasi-testsuite#52 See #1036 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
commented
Feb 5, 2023
Signed-off-by: Adrian Cole <[email protected]>
|
the testsuite repo is overlapping the wazero mount so not finding the exclude. I'll move it to the testsuite fork.. |
Signed-off-by: Adrian Cole <[email protected]>
|
ok finally works! technically, we aren't losing any coverage because we have a lot of tests around |
|
specifically, we have stat and entries tests for zig, clang, rust and go (GOOS=js) in our normal test tree, plus the zig integration tests, and when tinygo implements readdir we'll have those as well. |
mathetake
approved these changes
Feb 5, 2023
|
so, we are down to 3 legit failures from wasi-testsuite, now. We promised to pass all or have a very good reason for why not, so I think we're on track for this commitment by next version. |
evacchi
pushed a commit
to evacchi/wasi-testsuite
that referenced
this pull request
Aug 22, 2023
Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current fd_readdir test is invalid as it requires dot and dot-dot entries, which both aren't required by POSIX nor returned by go. Once this is addressed upstream, we can remove the skip.
See WebAssembly/wasi-testsuite#52
See #1036