Scrollable timeline #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the timeline to be scrollable, having the width of the scrollable content default to 3.2 times the size of the current window. This pretty much always makes it so that the times displayed on init are 12:00AM - 7:00AM like in the mockups. I went back and forth a lot last night on how the width should be defined, if it should be set or relative to the size of the window, but since the requirements were that it show 6 hours at a time I figured this was the best way to go. Lots of options available if we decide a set size is best.
It was asked if the content would scroll when you drag activity handlebars, and the good news is it does!
Here is a screen:
Am working now on getting the overlay bar with the time at the center updating properly. Isn't trivial at all.