Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pending support & tests updated #19

Merged
merged 4 commits into from
Jun 9, 2023
Merged

pending support & tests updated #19

merged 4 commits into from
Jun 9, 2023

Conversation

munderseth
Copy link
Contributor

Support for pending/skipped tests - #10.

Also updated tests to verify the counts for the Cypress Suite

@munderseth munderseth requested a review from ivailop June 7, 2023 19:33
ivailop
ivailop reviewed Jun 8, 2023
View reviewed changes
Copy link

@ivailop ivailop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In createTestRecord you need to special handle "skipped"/"pending" - need to add skipped sub-tag, similar to how failure is added for "failed"

BTW, does cypress/mocha treat differently pending and skip?

src/reporter.js Outdated Show resolved Hide resolved
src/reporter.js Show resolved Hide resolved
src/reporter.js Outdated Show resolved Hide resolved
@munderseth
Copy link
Contributor Author

In createTestRecord you need to special handle "skipped"/"pending" - need to add skipped sub-tag, similar to how failure is added for "failed"

BTW, does cypress/mocha treat differently pending and skip?

No - https://stackoverflow.com/questions/52814408/skipped-tests-in-mocha-shown-pending-in-report

@munderseth munderseth requested a review from ivailop June 8, 2023 14:54
ivailop
ivailop reviewed Jun 8, 2023
View reviewed changes
src/reporter.js Outdated Show resolved Hide resolved
@munderseth munderseth requested a review from ivailop June 9, 2023 14:14
@munderseth munderseth merged commit 367c117 into main Jun 9, 2023
@munderseth munderseth deleted the support-pending-tests branch June 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivailop ivailop ivailop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@munderseth @ivailop