fix: support puppeteer 17 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems Puppeteer 20 works without this fix, but in order to use Puppeteer 21 we need this again. I know this library is not longer really maintained but it would be really helpful that someone merges this. |
|
@clemp6r done |
|
@patrickhulce Are you able to also change the version number of the package and publish to NPM? |
|
@marcusds an automated script should have already published this, are you not seeing it? |
|
@patrickhulce I see it now, not sure why it was delayed. Thank you so much for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to support
.frameinstead of.executionContext