Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overcommit #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add overcommit #2

wants to merge 1 commit into from

Conversation

Nimmyjv
Copy link
Collaborator

@Nimmyjv Nimmyjv commented Jul 10, 2018

No description provided.

# `include`), whether to only display output if it fails (via `quiet`), etc.
#
# For a complete list of hooks, see:
# https://github.com/brigade/overcommit/tree/master/lib/overcommit/hook
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nimmyjv Remove the comments

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nimmyjv Are you still working on this?

Copy link
Owner

@tessie tessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Tag the Issue in commit. And Also update the Readme




PostCheckout:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nimmyjv What all are the default postcheckout hooks. Can you please comment here?

Its good to keep just bare minimum

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BowerInstall
BundleInstall
ComposerInstall
IndexTags
NpmInstall
SubmoduleStatus
YarnInstall

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nimmyjv Do we need all this ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this check.

# https://github.com/brigade/overcommit#configuration
#
# Uncomment the following lines to make the configuration take effect.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable hooks for CommitMessage Also

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the commit message hooks are enabled by default

TrailingWhitespace:
enabled: true

RubyLint:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is RubyLint and Rubocop different?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby-lint primarily focuses on logic related errors such as the use of non-existing variables instead of focusing on semantics (e.g. the amount of characters per line).
Rubylint is a sub-analyzer of rubocop.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nimmyjv Do we need to keep both? I felt we just need only ruby-lint

enabled: true
command: ['bundle', 'exec', 'ruby-lint']


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the yml file :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dint get it.. format means?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the format of yml file. Remove extra lines, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants