-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate cling to jupnp #2541
Merged
Merged
Migrate cling to jupnp #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add com.tesshu.jpsonic.service.upnp.transport - Add new server/client implementation
- Enable to change startup arguments of HTTP server for UPnP - Comment out non-essential items in production.synology.yml to make configuration easier to understand.
- Since Spring's Service class has become bloated, UPnP instantiation will be moved to a factory class.
- JUPnP's thread factory will be overridden
tesshucom
added
type: enhancement
A general enhancement
type: dependency-upgrade
A dependency upgrade
in: UPnP
Issues in UPnP
in: docker
Issues in the test module.
type: maintenance
Refactorings not related to logic, etc.
labels
Jan 15, 2024
2 tasks
tesshucom
added
the
type: breaking changes
Relevant announcement required upon release.
label
Jan 15, 2024
Since production.yml has been changed, an announcement is required at the time of release. It is backward compatible, so you can continue to use previous versions of yml as is. (Comments have been added to make configuration easier.) |
Closed
8 tasks
This was referenced Feb 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: docker
Issues in the test module.
in: UPnP
Issues in UPnP
type: breaking changes
Relevant announcement required upon release.
type: dependency-upgrade
A dependency upgrade
type: enhancement
A general enhancement
type: maintenance
Refactorings not related to logic, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cling, the library used for UPnP, will be migrated to Jupnp. Cling is already EOL. Jupnp is a derivative of Cling and is currently undergoing maintenance.
This will have the following impact on product configuration:
Details
Library changes and associated refactorings.
Unlike previous implementations, accepting UPnP queries will use a Java standard simple http server rather than a socket implementation. Along with this, tuning using some parameters is possible. Links for their default values and detailed information have been added as comments to production.yml.
Unlike previous implementations, Classes provided as standard by the library are not used for thread pool and thread factory. It has been replaced to using Spring's thread management mechanism via an adapter. The use of default implementation was be avoided in order to meet requirements such as shutsown being linked to the application lifecycle and shutdown flow, ensuring logging of UncaughtExceptions, and not accessing the SecurityManager.