Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix change detection in push event. #1938

Merged
merged 1 commit into from
Oct 22, 2024
Merged

ci: fix change detection in push event. #1938

merged 1 commit into from
Oct 22, 2024

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Oct 22, 2024

What this PR does / why we need it:

Terramate CI rollout releases in main and vX.Y.x branches. The PR #1933 works for previews but broke the TMC deployment because push events has no github.base_ref variable.

The solution is to compare against first parent commit (the default in Terramate but not in branches other than main);

Which issue(s) this PR fixes:

none

Special notes for your reviewer:

Does this PR introduce a user-facing change?

no

@i4ki i4ki requested a review from a team as a code owner October 22, 2024 16:38
Copy link

Preview of ubuntu-focal/go1.21 tests in 8e64775

🔍 View Details on Terramate Cloud

.

Copy link
Contributor

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Preview of macos-ventura/go1.21 tests in 8e64775

🔍 View Details on Terramate Cloud

.

@i4ki i4ki merged commit 5bd04da into main Oct 22, 2024
5 checks passed
@i4ki i4ki deleted the i4k-fix-deployment branch October 22, 2024 16:56
i4ki added a commit that referenced this pull request Oct 23, 2024
## What this PR does / why we need it:

Fix a missing case, sorry about that. This is a continuation of #1938 

## Which issue(s) this PR fixes:
none

## Special notes for your reviewer:

## Does this PR introduce a user-facing change?
```
no
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants