Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve ui mode detection #1302

Draft
wants to merge 1 commit into
base: release-v0.4.x
Choose a base branch
from

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented Dec 15, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Copy link

metric: time/op
CloudReadLines-4: old 975µs ± 4%: new 955µs ± 3%: delta: -2.11%
CloudReadLine-4: old 7.34ms ± 5%: new 7.17ms ± 1%: delta: -2.41%
ListFiles-4: old 51.9µs ± 1%: new 97.2µs ± 1%: delta: 87.18%
Generate-4: old 2.64s ± 2%: new 2.68s ± 2%: delta: 1.42%
GenerateRegex-4: old 1.79s ± 2%: new 1.81s ± 2%: delta: 0.93%
TokensForExpressionComplex-4: old 1.13ms ± 1%: new 1.13ms ± 2%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 932ns ± 1%: new 934ns ± 2%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 32.1µs ± 1%: new 33.7µs ± 2%: delta: 5.08%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 1.31ms ± 1%: new 1.28ms ± 1%: delta: -1.62%
TokensForExpression-4: old 1.15ms ± 1%: new 1.14ms ± 2%: delta: -1.08%
PartialEvalComplex-4: old 454µs ± 1%: new 441µs ± 2%: delta: -2.90%
PartialEvalSmallString-4: old 3.66µs ± 1%: new 3.61µs ± 1%: delta: -1.25%
PartialEvalHugeString-4: old 1.85ms ± 0%: new 1.84ms ± 0%: delta: -0.38%
PartialEvalHugeInterpolatedString-4: old 4.90ms ± 3%: new 4.91ms ± 2%: delta: 0.00%
PartialEvalObject-4: old 22.2µs ± 1%: new 21.9µs ± 2%: delta: -1.08%
check failed: time/op=+20%
metric: alloc/op
CloudReadLines-4: old 3.12MB ± 0%: new 3.12MB ± 0%: delta: 0.00%
CloudReadLine-4: old 3.37MB ± 0%: new 3.37MB ± 0%: delta: 0.00%
ListFiles-4: old 22.0kB ± 0%: new 99.5kB ± 0%: delta: 352.04%
Generate-4: old 2.31GB ± 0%: new 2.34GB ± 0%: delta: 1.08%
GenerateRegex-4: old 950MB ± 0%: new 962MB ± 0%: delta: 1.33%
TokensForExpressionComplex-4: old 412kB ± 0%: new 412kB ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 592B ± 0%: new 592B ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 14.0kB ± 0%: new 14.0kB ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 402kB ± 0%: new 402kB ± 0%: delta: -0.00%
TokensForExpression-4: old 412kB ± 0%: new 412kB ± 0%: delta: -0.00%
PartialEvalComplex-4: old 353kB ± 0%: new 353kB ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 1.74kB ± 0%: new 1.74kB ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 166kB ± 0%: new 166kB ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 4.38MB ± 0%: new 4.38MB ± 0%: delta: 0.00%
PartialEvalObject-4: old 20.4kB ± 0%: new 20.4kB ± 0%: delta: 0.00%
metric: allocs/op
CloudReadLines-4: old 5.54k ± 0%: new 5.54k ± 0%: delta: 0.00%
CloudReadLine-4: old 60.0k ± 0%: new 60.0k ± 0%: delta: 0.00%
ListFiles-4: old 321 ± 0%: new 474 ± 0%: delta: 47.66%
Generate-4: old 25.9M ± 0%: new 25.9M ± 0%: delta: 0.06%
GenerateRegex-4: old 18.3M ± 0%: new 18.3M ± 0%: delta: 0.08%
TokensForExpressionComplex-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
TokensForExpressionPlainStringNoNewline-4: old 21.0 ± 0%: new 21.0 ± 0%: delta: 0.00%
TokensForExpressionStringWith100Newlines-4: old 328 ± 0%: new 328 ± 0%: delta: 0.00%
TokensForExpressionObjectWith100KeysWithNumberValues-4: old 3.29k ± 0%: new 3.29k ± 0%: delta: 0.00%
TokensForExpression-4: old 4.93k ± 0%: new 4.93k ± 0%: delta: 0.00%
PartialEvalComplex-4: old 2.83k ± 0%: new 2.83k ± 0%: delta: 0.00%
PartialEvalSmallString-4: old 23.0 ± 0%: new 23.0 ± 0%: delta: 0.00%
PartialEvalHugeString-4: old 35.0 ± 0%: new 35.0 ± 0%: delta: 0.00%
PartialEvalHugeInterpolatedString-4: old 23.1k ± 0%: new 23.1k ± 0%: delta: 0.00%
PartialEvalObject-4: old 125 ± 0%: new 125 ± 0%: delta: 0.00%
check failed: allocs/op=+20%

@mariux
Copy link
Contributor

mariux commented Dec 18, 2023

@i4ki did you mean CI ?

@i4ki
Copy link
Contributor Author

i4ki commented Dec 18, 2023

@mariux actually no, it's not a good name but internally in Terramate CLI we have an "UI (User Interface)" mode that can be HumanMode or AutomationMode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants