fix(stdlib): tm_ternary() does not track expression scoped vars. #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some variables are scoped by their expression declaration, that's the
case for `[for ...]`, `{for ...}` and `tm_dynamic`.
In this case, the `tm_ternary()` implementation must use the provided
closure evaluator variables instead of the outer Terramate evaluator.
Signed-off-by: Tiago Natel <[email protected]>
i4ki
force-pushed
the
i4k-fix-eval-v2-ternary
branch
from
0f92726
to
19ba218
Compare
|
zied-elouaer
approved these changes
Dec 5, 2023
snakster
approved these changes
Dec 6, 2023
Co-authored-by: Sebastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some variables are scoped by their expression declaration, that's the case for
[for ...],{for ...}andtm_dynamic. In this case, thetm_ternary()implementation must use the provided closure evaluator variables instead of the outer Terramate evaluator.This fixes an issue where
tm_ternary()reported the error below:Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?