fix: install supported Terramate system/arch (excluding windows). #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i4ki
changed the title
i4ki
force-pushed
the
i4k-fix-macos
branch
3 times, most recently
from
5a0d9c6 to
8caae18
Compare
i4ki
force-pushed
the
i4k-fix-macos
branch
7 times, most recently
from
529b232 to
46929fd
Compare
Signed-off-by: i4k <[email protected]>
| @@ -18,7 +18,7 @@ get_latest_version() { | |||
| echo >&2 "latest version: Getting latest Terramate release information from GitHub Releases" | |||
|
|
|||
| latest_url="https://api.github.com/repos/terramate-io/terramate/releases/latest" | |||
| latest_json=$(curl -s "${latest_url}") | |||
| latest_json=$(curl -s -H "Authorization: Bearer ${GITHUB_TOKEN}" "${latest_url}") | |||
There was a problem hiding this comment.
/home/runner/_work/_actions/terramate-io/terramate-action/i4k-fix-macos/install.sh: line 21: GITHUB_TOKEN: unbound variable I got this error when running this line @i4ki
There was a problem hiding this comment.
Ah okay, this needs a fallback to be unauthenticated if the env is not set.
But the install requires fetching the latest Terramate release from Github API, so if unauthenticated you can get some rate limiting errors in your pipeline. Quick fix now is just pass the GITHUB_TOKEN to the action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the installation of the supported Terramate Operating System and architectures.
Windows support is still experimental, hence not implemented.