helper: Ignore issues order in helper.AssertIssues #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of terraform-linters/tflint-ruleset-terraform#216
Previously,
helper.AssertIssuesused in unit tests would even test whether the order of issues matched. However, the order in which the issues are emitted doesn't matter, as they will be sorted in the final output.The order of iterations over a map is random, which makes test with
AssertIssuesflaky. Given this, it may not be a good idea to test the order inAssertIssues.This PR adds
cmpopts.SortSlices, which sorts issues, as acmp.OptiontoAssertIssuesandAssertIssuesWithoutRange, allowing you to ignore the order of issues.