Introduce ephemeral marks #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
ephemeral_values
branch
from
4980d1b to
886b185
Compare
wata727
force-pushed
the
ephemeral_values
branch
from
886b185 to
0257356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform v1.10 introduced ephemeral values. This is treated internally as a
ctyvalue marked in the same way as sensitive. In order to send marked values to the plugin, this PR adds a new mark calledmarks.Ephemeraland extends the serialization process like #239.Please note that plugins built with older SDKs (v0.21 and below) that do not include this change will have ephemeral marks discarded on decoding. To prevent unintended disclosure due to this issue, host servers should take measures such as not returning
ctyvalues for older SDKs.If an ephemeral value is converted to a Go literal value, it returns
ErrEphemeral. If you are passing a function callback to theEvaluateExprAPI, this error is ignored internally, just likeErrSensitive, so there is nothing the caller needs to do. If your plugin is directly checking the return value ofEvaluateExprwitherrors.Isor using the deprecatedEnsureNoError, you will need to explicitly handleErrEphemeralor migrate to the function callback approach.