Fix bug with incorrect shared bucket name

README.md

@@ -70,11 +70,12 @@ Specific submodule docs can be found [in the submodule](secret-infrastructure/RE
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| application\_name | The application to fetch secrets for | string | - | yes |
-| credentials\_file\_path | The path to the GCP credentials | string | - | yes |
-| env | The environment to fetch secrets for | string | - | yes |
-| secret | The name of the secret to fetch | string | - | yes |
-| shared | Will we fetch the secret from the shared bucket instead of an application-specific bucket? | string | `false` | no |
+| application\_name | The application to fetch secrets for | string | n/a | yes |
+| credentials\_file\_path | The path to the GCP credentials | string | n/a | yes |
+| env | The environment to fetch secrets for | string | n/a | yes |
+| project\_name | The name of the project | string | n/a | yes |
+| secret | The name of the secret to fetch | string | n/a | yes |
+| shared | Will we fetch the secret from the shared bucket instead of an application-specific bucket? | string | `"false"` | no |
 
 ## Outputs
 

examples/bucket_example/README.md

@@ -16,8 +16,8 @@ Specific submodule docs can be found [in the submodule](../../modules/secret-inf
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | application\_list | The list of application names that will store secrets | list | `<list>` | no |
-| credentials\_file\_path | GCP credentials fils | string | - | yes |
+| credentials\_file\_path | GCP credentials fils | string | n/a | yes |
 | env\_list | The list of environments for secrets | list | `<list>` | no |
-| project\_name | The name of the project this applies to | string | - | yes |
+| project\_name | The name of the project this applies to | string | n/a | yes |
 
 [^]: (autogen_docs_end)

examples/fetch_secret/README.md

@@ -9,10 +9,10 @@ Specific submodule docs can be found [in the submodule](../../modules/gcs-object
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| application\_name | The application to fetch secrets for | string | - | yes |
-| credentials\_file\_path | GCP credentials fils | string | - | yes |
-| env | The environment to fetch secrets for | string | - | yes |
-| secret | The name of the secret to fetch | string | - | yes |
+| application\_name | The application to fetch secrets for | string | n/a | yes |
+| credentials\_file\_path | GCP credentials fils | string | n/a | yes |
+| env | The environment to fetch secrets for | string | n/a | yes |
+| secret | The name of the secret to fetch | string | n/a | yes |
 
 ## Outputs
 

main.tf

@@ -23,7 +23,7 @@ provider "google" {
 
 locals {
   //  secret_project = "${var.project_name}"
-  shared_bucket = "shared-${var.env}-secrets"
+  shared_bucket = "shared-${var.project_name}-${var.env}-secrets"
   app_bucket    = "${var.application_name}-${var.env}-secrets"
   bucket_name   = "${var.shared == "true" ? local.shared_bucket : local.app_bucket}"
   object_path   = "${var.secret}.txt"

modules/gcs-object/README.md

@@ -12,9 +12,9 @@ See the living [barebones](./examples/barebones-test-fixture) test fixture examp
 
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
-| bucket | The bucket to fetch the object from | string | - | yes |
-| duration | The duration of the signed URL (defaults to 1m) | string | `1m` | no |
-| path | The path to the desired object within the bucket | string | - | yes |
+| bucket | The bucket to fetch the object from | string | n/a | yes |
+| duration | The duration of the signed URL (defaults to 1m) | string | `"1m"` | no |
+| path | The path to the desired object within the bucket | string | n/a | yes |
 
 ## Outputs
 

modules/secret-infrastructure/README.md

@@ -42,16 +42,16 @@ Along with the shared buckets per environment
 | Name | Description | Type | Default | Required |
 |------|-------------|:----:|:-----:|:-----:|
 | application\_list | The list of application names that will store secrets | list | `<list>` | no |
-| credentials\_file\_path | GCP credentials fils | string | - | yes |
+| credentials\_file\_path | GCP credentials fils | string | n/a | yes |
 | env\_list | The list of environments for secrets | list | `<list>` | no |
-| project\_name | The name of the project this applies to | string | - | yes |
+| project\_name | The name of the project this applies to | string | n/a | yes |
 
 ## Outputs
 
 | Name | Description |
 |------|-------------|
-| app-buckets | - |
-| shared-buckets | - |
+| app-buckets |  |
+| shared-buckets |  |
 
 [^]: (autogen_docs_end)
 

variables.tf

@@ -22,6 +22,10 @@ variable "application_name" {
   description = "The application to fetch secrets for"
 }
 
+variable "project_name" {
+  description = "The name of the project"
+}
+
 variable "env" {
   description = "The environment to fetch secrets for"
 }