Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in description of access_log_delivery_policy_source_buckets variable #278

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

A-Ashiq
Copy link
Contributor

@A-Ashiq A-Ashiq commented Apr 15, 2024

Description

Candidate for smallest PR in history 😄 just a typo I spotted earlier today when I was using this module.
I promised myself I'd come back and raise a PR for it. Scouts rule and all that!

Motivation and Context

N/A

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

N/A

  • I have executed pre-commit run -a on my pull request

@A-Ashiq A-Ashiq changed the title Fix typo in description of access_log_delivery_policy_source_buckets variable fix: Typo in description of access_log_delivery_policy_source_buckets variable Apr 15, 2024
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect and small. Could you also update README with the same fix (to fix GH checks)?

@A-Ashiq
Copy link
Contributor Author

A-Ashiq commented Apr 16, 2024

Almost perfect and small. Could you also update README with the same fix (to fix GH checks)?

Ahh thanks! Done in 0d504b6

@antonbabenko antonbabenko merged commit b4a5347 into terraform-aws-modules:master Apr 16, 2024
14 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 16, 2024
## [4.1.2](v4.1.1...v4.1.2) (2024-04-16)

### Bug Fixes

* Typo in description of `access_log_delivery_policy_source_buckets` variable ([#278](#278)) ([b4a5347](b4a5347))
@antonbabenko
Copy link
Member

This PR is included in version 4.1.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants