-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Added support for date-based partitioning. Bump AWS provider version to 5.x and Terraform to 1.0 #268
feat!: Added support for date-based partitioning. Bump AWS provider version to 5.x and Terraform to 1.0 #268
Conversation
I was just about to submit a PR for this myself and then realized I had overlooked yours, @EreminAnton . I approached this a little differently:
partition_date_source = target_object_key_format.value.partitioned_prefix["partition_date_source"] I also chose different logic for the for_each = try([target_object_key_format.value.simple_prefix], []) Those are the only differences that I'm aware of. Testing my fork by generating plans seemed to work well. Errors, as expected, were thrown:
Otherwise, the plans came back successful. I am not sure which approach is best but thought I'd comment here for review. |
I was about to submit a patch for this as well, but thought I should look at open PRs first. Good thing I did, saved me the effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update versions.tf
everywhere to require the minimum version of AWS provider 5.27 and Terraform 1.0 (this will fix the failing CI runs).
Hello! I have updated versions.tf. However, the pre-commit Terraform wrapper with for_each in the module has resulted in numerous changes in the /wrappers directory. I'm unsure if this is the expected outcome. |
f8531e4
into
terraform-aws-modules:master
This PR is included in version 4.0.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add optional target_object_key_format configuration block to support automatic date-based partitioning. This functionality was released in 5.27.0 version of AWS provider.
Motivation and Context
To leverage the new functionality of access logging.
Breaking Changes
As I understand it, this pins the provider's version to 5.27.0 but offers a significant update in access logs partitioning.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectsI deployed every possible combination of the target_object_key_format configuration, placed objects, and waited until access logs arrived in the required format.
pre-commit run -a
on my pull request