Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use variable to enable EKS cluster creation with CONFIG_MAP authentication mode #3270

Closed
wants to merge 1 commit into from

Conversation

hsalluri259
Copy link

@hsalluri259 hsalluri259 commented Jan 10, 2025

Description

Using enable_cluster_creator_admin_permissions variable for bootstrap_cluster_creator_admin_permissions in place of hard coded false value to support EKS cluster creation when authentication mode is CONFIG_MAP only. I think alternatively we can use API_AND_CONFIG_MAP, but this will take time for us to migrate our clusters and customers clusters.

Motivation and Context

It allows a user to create an EKS cluster when authentication mode is CONFIG_MAP only by using bootstrap_cluster_creator_admin_permissions=true .
Without this value, the user will be facing the below error.

Error: creating EKS Cluster (k8s-dev-eks-xyz: operation error EKS: CreateCluster, https response error StatusCode: 400, RequestID: eec24135-0159-484f-b0d7-b5c5518b3cd5, InvalidParameterException: bootstrapClusterCreatorAdminPermissions must be true if cluster authentication mode is set to CONFIG_MAP

It fixes the following open issue.
#3247

Breaking Changes

The default value for bootstrap_cluster_creator_admin_permissions variable is still false. So it doesn't break anything.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@hsalluri259 hsalluri259 changed the title Use variable to enable EKS cluster creation with CONFIG_MAP authentication mode fix: Use variable to enable EKS cluster creation with CONFIG_MAP authentication mode Jan 10, 2025
@hsalluri259 hsalluri259 marked this pull request as ready for review January 10, 2025 00:21
@bryantbiggs
Copy link
Member

Thank you, however this is not a valid change and we have no plans to modify this value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants