Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.1 upgrade - Farnesene #159

Merged
merged 9 commits into from
Nov 29, 2023
Merged

v4.1 upgrade - Farnesene #159

merged 9 commits into from
Nov 29, 2023

Conversation

discoverdefiteam
Copy link
Contributor

No description provided.

@discoverdefiteam
Copy link
Contributor Author

covers #156


"github.com/terpnetwork/terp-core/v4/x/tokenfactory/bindings"
tokenfactorykeeper "github.com/terpnetwork/terp-core/v4/x/tokenfactory/keeper"
tokenfactorytypes "github.com/terpnetwork/terp-core/v4/x/tokenfactory/types"
)

var (
wasmCapabilities = "iterator,staking,stargate,token_factory,cosmwasm_1_1,cosmwasm_1_2,cosmwasm_1_3,cosmwasm_1_4,tokenfactory"
wasmCapabilities = "iterator,staking,stargate,token_factory,cosmwasm_1_1,cosmwasm_1_2,cosmwasm_1_3,cosmwasm_1_4,cosmwasm_1_5,tokenfactory"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 token_factory and tokenfactory

CreateUpgradeHandler: CreateV4_1UpgradeHandler,
StoreUpgrades: store.StoreUpgrades{
Added: []string{
driptypes.ModuleName,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did v4 get into prod with the burn module? if so make sure to Remove that store key here, not just remove the keeper

Copy link
Collaborator

@hard-nett hard-nett Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you following up here! The burn module only made it to our test network 90u-2. Is it certain the burn module needs the store key removed? We do not have a store key specified here, and we also did not specify the module stored in the v4 upgrade.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh good call. was a busy day and forgot it's more of a plugin vs module

so my comment does no apply, you're all good

Copy link
Collaborator

@hard-nett hard-nett Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, thank you!

@hard-nett hard-nett mentioned this pull request Nov 29, 2023
@hard-nett hard-nett merged commit 4e98813 into main Nov 29, 2023
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants