-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.1 upgrade - Farnesene #159
Conversation
covers #156 |
|
||
"github.com/terpnetwork/terp-core/v4/x/tokenfactory/bindings" | ||
tokenfactorykeeper "github.com/terpnetwork/terp-core/v4/x/tokenfactory/keeper" | ||
tokenfactorytypes "github.com/terpnetwork/terp-core/v4/x/tokenfactory/types" | ||
) | ||
|
||
var ( | ||
wasmCapabilities = "iterator,staking,stargate,token_factory,cosmwasm_1_1,cosmwasm_1_2,cosmwasm_1_3,cosmwasm_1_4,tokenfactory" | ||
wasmCapabilities = "iterator,staking,stargate,token_factory,cosmwasm_1_1,cosmwasm_1_2,cosmwasm_1_3,cosmwasm_1_4,cosmwasm_1_5,tokenfactory" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 token_factory and tokenfactory
CreateUpgradeHandler: CreateV4_1UpgradeHandler, | ||
StoreUpgrades: store.StoreUpgrades{ | ||
Added: []string{ | ||
driptypes.ModuleName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did v4 get into prod with the burn module? if so make sure to Remove that store key here, not just remove the keeper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you following up here! The burn module only made it to our test network 90u-2
. Is it certain the burn module needs the store key removed? We do not have a store key specified here, and we also did not specify the module stored in the v4 upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh good call. was a busy day and forgot it's more of a plugin vs module
so my comment does no apply, you're all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries, thank you!
No description provided.