Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get coord type and get all cores #483

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Get coord type and get all cores #483

wants to merge 2 commits into from

Conversation

broskoTT
Copy link
Contributor

Issue

Heading towards #439

Description

Added some APIs needed by tt_metal for switching to new UMD API using CoreCoords.

List of the changes

  • Added get_coord_type, and made translate_coord_to going through it
  • Added get_all_cores and get_all_harvested_cores to soc descriptor
  • Added ROUTER_ONLY cores to cores_map, so it is available in get_cores api.
  • Rewrote cores_map addition to be more compact.
  • Added tests for get_all_cores

Testing

(Comment on CI testing or Manual testing touching this change.)

API Changes

There are no API changes in this PR.

@broskoTT broskoTT requested a review from pjanevskiTT January 23, 2025 22:31
@broskoTT broskoTT changed the title Brosko/get coord type Get coord type and get all cores Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanevskiTT pjanevskiTT Awaiting requested review from pjanevskiTT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@broskoTT