HarvestingMasks struct

[pjanevskiTT]

Issue

#435

Description

Add struct for software harvesting which should be used to simulate all 3 types of harvesting (Tensix, DRAM, ETH)

List of the changes

• Add struct for software harvesting
• Integrate it into Cluster

Testing

CI

API Changes

/

[abhullar-tt]

will the software harvesting + silicon harvesting masks be combined or is the idea for users to query both and combine them?

[pjanevskiTT]

Well we need to apply silicon harvesting masks always in order to not hang. Software harvesting is combined at the moment with silicon masks. I am happy to change that anyway you want, this is probably never going to be used by UMD, it is mostly for clients like tt-lens and tt-metal. If you have any idea how to implement this with different API let me know

[abhullar-tt]

Well we need to apply silicon harvesting masks always in order to not hang. Software harvesting is combined at the moment with silicon masks. I am happy to change that anyway you want, this is probably never going to be used by UMD, it is mostly for clients like tt-lens and tt-metal. If you have any idea how to implement this with different API let me know

Internally if UMD stores software/silicon masks separately that is okay but would prefer if they are exposed together just as HarvestingMask

[pjanevskiTT]

Sure, is logical representation of harvesting masks good for you? That means if bit 0 is set, 0 logical row of tensix is harvested, bank 0 and eth channel 0?

[abhullar-tt]

Sure, is logical representation of harvesting masks good for you? That means if bit 0 is set, 0 logical row of tensix is harvested, bank 0 and eth channel 0?

yeah that is okay, its different than today (I think we get physical rows)

[broskoTT]

Client should not have an option to not harvest truly harvested hw rows.
I think today we do combine whatever is passed as simulated harvesting mask with the one reported in cluster descriptor, and I think it should stay that way.

[pjanevskiTT]

I put all harvesting masks into a struct, so now those can be expose together as Almeet suggested. Patched the tests as well

[broskoTT]

looking good!