[Harvesting] Move tt_SocDescriptor accessors to new API inside UMD #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanevskiTT
reviewed
Jan 8, 2025
broskoTT
force-pushed
the
brosko/harvest_soc_private
branch
from
5fa4901 to
69edb64
Compare
pjanevskiTT
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR towards #439
Description
There are currently workers inside tt_socDescriptor, and then another version inside its coordinate manager. Same for other types of cores.
This PR moves as much as it can to the new API. The final touch will be done when finally removing completely the cluster's version of harvesting.
List of the changes
Testing
Existing CI test should be fine.
API Changes
There are no API changes in this PR.
I've left the accessors public, even though I've removed the usage at most places in UMD repo. This will allow us to remove this subsequently in tt_metal, and only then move it to private here.