#0: Hoist SubDeviceManager/Lock-Step Allocator to MeshDevice #16878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfjchu
requested review from
aliuTT,
tt-asaigal,
omilyutin-tt,
abhullar-tt,
pgkeller,
tt-aho,
tt-dma and
ubcheema
as code owners
cfjchu
force-pushed
the
jchu/mesh-allocator
branch
from
1f34d17 to
92a2dd9
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
cfjchu
force-pushed
the
jchu/mesh-allocator
branch
from
92a2dd9 to
d91d8e5
Compare
tt-asaigal
reviewed
Jan 20, 2025
cfjchu
force-pushed
the
jchu/mesh-allocator
branch
2 times, most recently
from
5968a64 to
2f3c743
Compare
cfjchu
force-pushed
the
jchu/mesh-allocator
branch
4 times, most recently
from
89a2fd9 to
a04ce94
Compare
tt-aho
approved these changes
Jan 23, 2025
tt-asaigal
approved these changes
Jan 23, 2025
cfjchu
force-pushed
the
jchu/mesh-allocator
branch
from
a04ce94 to
6558bf9
Compare
cfjchu
force-pushed
the
jchu/mesh-allocator
branch
from
6558bf9 to
86d6a3b
Compare
|
|
||
| void initialize(); | ||
| std::unique_ptr<SubDeviceManagerTracker> sub_device_manager_tracker_; | ||
| std::unique_ptr<WorkExecutor> work_executor_; |
There was a problem hiding this comment.
I mentioned this yesterday... This is being added to provide implementations for IDevice interface for executor methods like push_work. Right now I'm defaulting executor to work in synchronous mode. This was added so that Buffer::create -> calls push_work -> requires executor methods on MeshDevice.
Separate discussion needs to be had about removing this from IDevice interface but my goal is to unify the APIs, as-is and to do so incrementally to prepare for TT-NN integration.
omilyutin-tt
approved these changes
Jan 24, 2025
ayerofieiev-tt
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
As part of the TT-Mesh scope of work, we want to natively virtualize the devices in the mesh. Part of this virtualization process involves deferring to a single set of allocators (global, per-subdevice) at the MeshDevice level, instead of issuing repeated allocations on each of the per-device allocators.
What's changed
SubDeviceManagerTrackerto the MeshDevice level.Checklist