Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vecadd sharding #16654

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Feature/vecadd sharding #16654

merged 3 commits into from
Jan 21, 2025

Conversation

dchenTT
Copy link
Contributor

@dchenTT dchenTT commented Jan 13, 2025

Ticket

Link to Github Issue

Problem description

A new programming example of vecadd using sharding

What's changed

  1. Provide examples for sharding type of HEIGHT, WIDTH, and BLOCK.
  2. Host create sharded buffer on L1 directly.
  3. Host write vector a and b to L1 sharded buffer, read c from L1 to host. No read and write kernel is needed. Only compute kernel.
  4. cb buffer points to L1 buffer address with global address.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

1. Provide examples for sharding type of HEIGHT, WIDTH, and BLOCK.
2. Host create sharded buffer on L1 directly.
3. Host write vector a and b to L1 sharded buffer, read c from L1 to host. No read and write kernel is needed. Only compute kernel.
4. cb buffer points to L1 buffer address with global address.
Address code review comments and piggy back two file header changes
@dchenTT dchenTT force-pushed the feature/vecadd_sharding branch from b782a46 to 409fdb2 Compare January 13, 2025 23:22
Comments spelling correction
@dchenTT dchenTT merged commit 51eee95 into main Jan 21, 2025
9 checks passed
@dchenTT dchenTT deleted the feature/vecadd_sharding branch January 21, 2025 23:37
@dchenTT dchenTT restored the feature/vecadd_sharding branch January 22, 2025 01:38
TT-billteng added a commit that referenced this pull request Jan 22, 2025
TT-billteng added a commit that referenced this pull request Jan 22, 2025
@dchenTT dchenTT deleted the feature/vecadd_sharding branch January 25, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants