-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/vecadd sharding #16654
Merged
Merged
Feature/vecadd sharding #16654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchenTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
January 13, 2025 05:34
dchenTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na and
bbradelTT
as code owners
January 13, 2025 07:13
tt_metal/programming_examples/vecadd_sharding/kernels/add_sharding.cpp
Outdated
Show resolved
Hide resolved
tt_metal/programming_examples/vecadd_sharding/vecadd_sharding.cpp
Outdated
Show resolved
Hide resolved
tt_metal/programming_examples/vecadd_sharding/vecadd_sharding.cpp
Outdated
Show resolved
Hide resolved
tt_metal/programming_examples/vecadd_sharding/vecadd_sharding.cpp
Outdated
Show resolved
Hide resolved
tt_metal/programming_examples/vecadd_sharding/vecadd_sharding.cpp
Outdated
Show resolved
Hide resolved
tt_metal/programming_examples/vecadd_sharding/vecadd_sharding.cpp
Outdated
Show resolved
Hide resolved
dchenTT
requested review from
a team,
esmalTT,
uaydonat,
dvartaniansTT,
cglagovichTT,
johanna-rock-tt,
djordje-tt,
kpaigwar,
skhorasganiTT and
sraizada-tt
as code owners
January 13, 2025 20:37
dchenTT
requested review from
yan-zaretskiy,
eyonland,
xanderchin,
jdesousa-TT,
SeanNijjar,
jvegaTT,
yugaoTT,
ntarafdar,
jaykru-tt,
yugi957,
llongTT,
nardoTT,
davorchap and
a team
as code owners
January 13, 2025 20:37
dchenTT
force-pushed
the
feature/vecadd_sharding
branch
3 times, most recently
from
January 13, 2025 23:06
b269c09
to
7b61d17
Compare
1. Provide examples for sharding type of HEIGHT, WIDTH, and BLOCK. 2. Host create sharded buffer on L1 directly. 3. Host write vector a and b to L1 sharded buffer, read c from L1 to host. No read and write kernel is needed. Only compute kernel. 4. cb buffer points to L1 buffer address with global address.
Address code review comments and piggy back two file header changes
dchenTT
force-pushed
the
feature/vecadd_sharding
branch
from
January 13, 2025 23:22
b782a46
to
409fdb2
Compare
eyonland
approved these changes
Jan 21, 2025
tt-aho
approved these changes
Jan 21, 2025
tt_metal/programming_examples/vecadd_sharding/vecadd_sharding.cpp
Outdated
Show resolved
Hide resolved
Comments spelling correction
TT-billteng
added a commit
that referenced
this pull request
Jan 22, 2025
This reverts commit 51eee95.
TT-billteng
added a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
A new programming example of vecadd using sharding
What's changed
Checklist