Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSC — Explicitly mark AOT incompatible targets via 'jit:true' #6886

Merged
merged 1 commit into from
Jul 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ import {
} from '../types';
import {AppRoutingEffects, TEST_ONLY} from './app_routing_effects';

@Component({selector: 'test', template: ''})
@Component({selector: 'test', template: '', jit: true})
class TestableComponent {}

const testAction = createAction('[TEST] test action');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
@Component({
selector: 'testable-feature-flag-dialog-container',
template: '<div>Test</div>',
jit: true,
})
class TestableFeatureFlagDialogContainer {}

Expand Down
1 change: 1 addition & 0 deletions tensorboard/webapp/plugins/testing/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ export class ExtraDashboardComponent {}
imports: [
PluginRegistryModule.forPlugin('extra-plugin', ExtraDashboardComponent),
],
jit: true,
})
export class ExtraDashboardModule {}
1 change: 1 addition & 0 deletions tensorboard/webapp/testing/integration_test_module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@ export function provideRoute(): RouteDef[] {
],
declarations: [TestableComponent],
exports: [TestableComponent],
jit: true,
})
export class IntegrationTestSetupModule {}
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,6 @@ export class TestingTBFeatureFlagDataSource extends TBFeatureFlagDataSource {
useExisting: TestingTBFeatureFlagDataSource,
},
],
jit: true,
})
export class TBFeatureFlagTestingModule {}
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@ import {TBHttpClientModule} from './tb_http_client_module';
),
}),
],
jit: true,
})
export class TBHttpClientTestingModule {}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {Directive, EventEmitter, NgModule, Output} from '@angular/core';
import {ComponentFixture} from '@angular/core/testing';
import {By} from '@angular/platform-browser';

@Directive({selector: '[observeIntersection]'})
@Directive({selector: '[observeIntersection]', jit: true})
class IntersectionObserverTestingDirective {
@Output() onVisibilityChange = new EventEmitter<{visible: boolean}>();

Expand All @@ -28,6 +28,7 @@ class IntersectionObserverTestingDirective {
@NgModule({
exports: [IntersectionObserverTestingDirective],
declarations: [IntersectionObserverTestingDirective],
jit: true,
})
export class IntersectionObserverTestingModule {
simulateVisibilityChange<T>(fixture: ComponentFixture<T>, visible: boolean) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class ResizeDetectorTestingDirective {
@NgModule({
exports: [ResizeDetectorTestingDirective],
declarations: [ResizeDetectorTestingDirective],
jit: true,
})
export class ResizeDetectorTestingModule {
simulateResize<T>(fixture: ComponentFixture<T>) {
Expand Down
Loading