Skip to content

Commit

Permalink
Automated g4 rollback of changelist 669103619.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

Broke TAP tests the LegoML project

*** Original change description ***

Mark message types as requiring the go/jspb object format methods.

This CL marks types that use the JSPB object format accessors (see go/jspb-api-gotchas#objects) so that we do not remove them in the future. This is a backwards compatibility option and will represent no immediate change.

The implementations of these methods are large and expensive for the JSCompiler to process; so we intend to limit their generation to improve compilation performance. See go/lsc-constrain-jspb-object-format-us...

***

PiperOrigin-RevId: 670640538
  • Loading branch information
tf-metadata-team authored and tfx-copybara committed Sep 3, 2024
1 parent 2ad4ebe commit cff231e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions tensorflow_metadata/proto/v0/schema.proto
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package tensorflow.metadata.v0;
import "google/protobuf/any.proto";
import "tensorflow_metadata/proto/v0/derived_feature.proto";
import "tensorflow_metadata/proto/v0/path.proto";

// GOOGLE-LEGACY option jspb_use_correct_proto2_semantics = false;
option cc_enable_arenas = true;
option java_package = "org.tensorflow.metadata.v0";
Expand Down
1 change: 1 addition & 0 deletions tensorflow_metadata/proto/v0/statistics.proto
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ package tensorflow.metadata.v0;
import "google/protobuf/any.proto";
import "tensorflow_metadata/proto/v0/derived_feature.proto";
import "tensorflow_metadata/proto/v0/path.proto";

option cc_enable_arenas = true;
option java_package = "org.tensorflow.metadata.v0";
option java_multiple_files = true;
Expand Down

0 comments on commit cff231e

Please sign in to comment.