[Reset] Override ID reuse and conflict policy when starting child #7236
+1,479
−1,371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nInfo for tracking child workflows post-reset
gow
changed the title
gow
changed the title
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
6015fef to
2814a46
Compare
gow
force-pushed
the
cg/reset_before_child_init_1
branch
from
2814a46 to
695190a
Compare
yycptt
reviewed
Feb 4, 2025
| @@ -37,6 +37,7 @@ message ParentExecutionInfo { | |||
| int64 initiated_id = 4; | |||
| temporal.server.api.clock.v1.VectorClock clock = 5; | |||
| int64 initiated_version = 6; | |||
| bool is_reset_run = 7; | |||
There was a problem hiding this comment.
I'd probably make this a ChildWorkflowOnly field in StartWorkflowExecutionRequest, similar to what we have in Terminate/CancelWorkflowExecutionRequest. You only need it perform a parent/child check when terminating the current child right?
We can put the field here but also need to update other usages of this message I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
is_reset_runin ParentExecutionInfostartRequest.WorkflowIdReusePolicy&startRequest.WorkflowIdConflictPolicyfor children that were recorded in theexecutionInfo.ChildrenInitializedPostResetPointexecutionInfo.ChildrenInitializedPostResetPoint[childID] = falseso that we don't do this again if the parent starts another instance of the same child.Why?
This is needed so that the parent can terminate any running children that were started in the previous run. Without this after reset, the parent may not make progress.
How did you test it?
Manual testing. Will add functional tests in followup PRs once the feature is ready.
Potential risks
N/A
Documentation
No. Documentation change is pending.
Is hotfix candidate?
No