Pass task queue types to Describe and take unecessary info out of TaskQueueFamilyData #7234
+1,213
−1,031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
changed the title
carlydf
commented
Feb 4, 2025
proto/internal/temporal/server/api/persistence/v1/task_queues.proto
Outdated
Show resolved
Hide resolved
Shivs11
approved these changes
Feb 4, 2025
proto/internal/temporal/server/api/persistence/v1/task_queues.proto
Outdated
Show resolved
Hide resolved
Shivs11
reviewed
Feb 4, 2025
Comment on lines
276
to
285
| for tqName, byType := range state.TaskQueueFamilies { | ||
| for tqType, oldData := range byType.TaskQueues { | ||
|
|
||
| syncReq.Sync = append(syncReq.Sync, &deploymentspb.SyncDeploymentVersionUserDataRequest_SyncUserData{ | ||
| Name: tqName, | ||
| Type: enumspb.TaskQueueType(tqType), | ||
| Data: oldData, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
I seem to be missing something here - why are we removing this piece of code? According to me, when forgetting a version, we still have to specify the task-queues and the types from where the version would be forgotten from - this piece of code seems to be doing that
There was a problem hiding this comment.
I got confused, just meant to remove the data part. Fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
CheckIfTaskQueuesHavePollersactivity so that we check pollers for only the task queue types that are registered in that version.DeploymentVersionDatafrom the per-type map inTaskQueueFamilyData.DeploymentVersionDatastores the same info asVersionLocalState, so repeating it num_task_queue times inside the VersionLocalState was a waste of space, and kind of confusing. I spoke with Shahab yesterday about howTaskQueueFamilyDatashould contain information that is specific to each task queue type within that version. So far, the only data that is specific to the version + task queue tuple isfirst_poller_time, so I put that in a newTaskQueueVersionDatastruct and put it inTaskQueueFamilyData.Why?
See explanation above.
How did you test it?
Tested that the existing Versioning 3.1 functional tests still work.
Potential risks
Documentation
Is hotfix candidate?