Delete Namespace: fix validation of replicated namespace #7069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
fix/delete-ns-replication-validation
branch
from
ae508e9 to
8e11655
Compare
yux0
approved these changes
Jan 10, 2025
bergundy
pushed a commit
that referenced
this pull request
Jan 10, 2025
## What changed? <!-- Describe what has changed in this PR --> Delete Namespace: fix validation of replicated namespace. ## Why? <!-- Tell your future self why have you made these changes --> Namespace should be deletable when: 1. It is active in the current cluster (even if replicated), 2. Doesn't belong to current cluster (current cluster was removed from cluster list). ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Added new tests, existing tests, manual run. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> No risks. ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> No. ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Delete Namespace: fix validation of replicated namespace.
Why?
Namespace should be deletable when:
How did you test it?
Added new tests, existing tests, manual run.
Potential risks
No risks.
Documentation
No.
Is hotfix candidate?
No.