Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testvars usage in versioning3 tests #7066

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

alexshtin
Copy link
Member

@alexshtin alexshtin commented Jan 10, 2025

What changed?

Fix testvars usage in versioning3 tests.

Why?

Use testvars as intended.

How did you test it?

Run it.

Potential risks

No risks.

Documentation

No.

Is hotfix candidate?

No.

@alexshtin alexshtin requested a review from a team as a code owner January 10, 2025 07:08
@alexshtin alexshtin requested review from ShahabT and Shivs11 January 10, 2025 07:27
@alexshtin alexshtin force-pushed the refactor/verisoning-3-tests branch from 9d89107 to 3a70f6a Compare January 11, 2025 01:35
Copy link
Member

@Shivs11 Shivs11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this - I went through this after our sync and see your point clearly

@alexshtin alexshtin force-pushed the refactor/verisoning-3-tests branch from 3a70f6a to 2ab626d Compare January 15, 2025 20:15
@alexshtin alexshtin enabled auto-merge (squash) January 15, 2025 20:33
@alexshtin alexshtin merged commit 7c03c16 into temporalio:main Jan 15, 2025
49 checks passed
@alexshtin alexshtin deleted the refactor/verisoning-3-tests branch January 15, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants