Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestDeploymentSuite/TestBatchUpdateWorkflowExecutionOptions_SetPinnedThenUnset flake #7058

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

carlydf
Copy link
Contributor

@carlydf carlydf commented Jan 8, 2025

What changed?

  • Increase max concurrent batch jobs from 1 to 3 in DeploymentTestSuite
  • Sleep and retry if max concurrent batch operations is hit

Why?

TestDeploymentSuite/TestBatchUpdateWorkflowExecutionOptions_SetPinnedThenUnset was flaking due to "Max concurrent batch operations is reached"

How did you test it?

Potential risks

Documentation

Is hotfix candidate?

…peration errors due to max concurrent batch operations
@carlydf carlydf requested a review from a team as a code owner January 8, 2025 02:06
Copy link
Member

@Shivs11 Shivs11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@carlydf carlydf merged commit a862298 into main Jan 9, 2025
49 checks passed
@carlydf carlydf deleted the cdf/fix-concurrent-batch-flake branch January 9, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants