Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ClientStatsHandler in func tests #7034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephanos
Copy link
Contributor

@stephanos stephanos commented Dec 24, 2024

What changed?

In functional tests, use the ClientStatsHandler, too (in additional to the ServerStatsHandler).

Why?

Without the ClientStatsHandler, the spans don't track their parent span ID correctly. Which makes it impossible to connect the spans again.

How did you test it?

Notice how the spans are all connected from Frontend to History:

Screenshot 2024-12-24 at 8 19 30 AM

Potential risks

Documentation

Is hotfix candidate?

@stephanos stephanos marked this pull request as ready for review December 24, 2024 16:20
@stephanos stephanos requested a review from a team as a code owner December 24, 2024 16:20
@stephanos stephanos requested a review from alexshtin December 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant