Delete Namespace: clean up errors #7029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/delete-ns-cleanup-errors
branch
from
4d9519b to
c25a272
Compare
ychebotarev
approved these changes
Dec 23, 2024
| @@ -88,11 +88,19 @@ func (a *localActivities) GetNamespaceInfoActivity(ctx context.Context, nsID nam | |||
|
|
|||
| getNamespaceResponse, err := a.metadataManager.GetNamespace(ctx, getNamespaceRequest) | |||
| if err != nil { | |||
| var nsNotFoundErr *serviceerror.NamespaceNotFound | |||
| if stderrors.As(err, &nsNotFoundErr) { | |||
| ns := nsName.String() | |||
There was a problem hiding this comment.
surprised this is not a part of a regular NamespaceNotFound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Clean up errors in delete namespace workflows:
FailedPreconditioninstead ofInvalidArgumentwhere it makes more sense.ApplicationErrors of different type.unable to execute activityerror which was wrongly used in many places.Why?
Simplify and unify error handling in delete namespace workflows.
How did you test it?
Modified tests. Manual runs.
Potential risks
No risks.
Documentation
No.
Is hotfix candidate?
No.