Move _set_running_loop up the stack #599
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR, investigating where we can / should set/unset the running loop.
Currently it's set/unset on entry/exit of
_run_once()
. Is the purpose of that to prevent any execution of workflow coroutines at any other time duringactivate()
?If so: CI is green when we do the setting/unsetting at the top level in
activate()
: it would be great to have a failing test demonstrating the necessity of confining the execution to_run_once()
.