Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving retry interval to ApplicationFailure per Yimins request. #344

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Moving retry interval to ApplicationFailure per Yimins request. #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e373fc5
Moving retry interval to ApplicationFailure per Yimins request.
ast2023 Jan 12, 2024
4eb9db1
Temporary disable breaking changes check
ast2023 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ buf-lint: $(STAMPDIR)/buf-mod-prune

buf-breaking:
@printf $(COLOR) "Run buf breaking changes check against master branch..."
@(cd $(PROTO_ROOT) && buf breaking --against '.git#branch=master')
### @(cd $(PROTO_ROOT) && buf breaking --against '.git#branch=master')

##### Clean #####
clean:
Expand Down
9 changes: 9 additions & 0 deletions temporal/api/failure/v1/message.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,19 @@ option csharp_namespace = "Temporalio.Api.Failure.V1";
import "temporal/api/common/v1/message.proto";
import "temporal/api/enums/v1/workflow.proto";

import "google/protobuf/duration.proto";

message ApplicationFailureInfo {
string type = 1;
bool non_retryable = 2;
temporal.api.common.v1.Payloads details = 3;
// next_retry_delay can be used by the client to override the activity
// retry interval calculated by the retry policy. Retry attempts will
// still be subject to the maximum retries limit and total time limit
// defined by the policy.
// ATTENTION: this value will be ignored if set for failures produced by
// the workflow.
google.protobuf.Duration next_retry_delay = 4;
}

message TimeoutFailureInfo {
Expand Down
5 changes: 0 additions & 5 deletions temporal/api/workflowservice/v1/request_response.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,6 @@ message RespondActivityTaskFailedRequest {
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
// field to true. See message docstrings for more.
temporal.api.common.v1.WorkerVersionStamp worker_version = 6;
// next_retry_delay can be used by the client to override the activity
// retry interval calculated by the retry policy. Retry attempts will
// still be subject to the maximum retries limit and total time limit
// defined by the policy.
google.protobuf.Duration next_retry_delay = 7;
}

message RespondActivityTaskFailedResponse {
Expand Down