address comment

temporalio · Dec 4, 2024 · e9b2dbe · e9b2dbe
1 parent e5bc2ed
commit e9b2dbe
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/openapi/openapiv2.json b/openapi/openapiv2.json
@@ -10860,10 +10860,11 @@
         "RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
         "RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL",
         "RESET_REAPPLY_EXCLUDE_TYPE_UPDATE",
-        "RESET_REAPPLY_EXCLUDE_TYPE_NEXUS"
+        "RESET_REAPPLY_EXCLUDE_TYPE_NEXUS",
+        "RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST"
       ],
       "default": "RESET_REAPPLY_EXCLUDE_TYPE_UNSPECIFIED",
-      "description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point."
+      "description": "Event types to exclude when reapplying events beyond the reset point.\n\n - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL: Exclude signals when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE: Exclude updates when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS: Exclude nexus events when reapplying events beyond the reset point.\n - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST: Exclude cancel request events when reapplying events beyond the reset point."
     },
     "v1ResetReapplyType": {
       "type": "string",

diff --git a/openapi/openapiv3.yaml b/openapi/openapiv3.yaml
@@ -8163,6 +8163,7 @@ components:
               - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL
               - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE
               - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS
+              - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST
             type: string
             format: enum
           description: Event types not to be reapplied
@@ -8249,6 +8250,7 @@ components:
               - RESET_REAPPLY_EXCLUDE_TYPE_SIGNAL
               - RESET_REAPPLY_EXCLUDE_TYPE_UPDATE
               - RESET_REAPPLY_EXCLUDE_TYPE_NEXUS
+              - RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST
             type: string
             format: enum
           description: Event types not to be reapplied

diff --git a/temporal/api/enums/v1/reset.proto b/temporal/api/enums/v1/reset.proto
@@ -40,8 +40,8 @@ enum ResetReapplyExcludeType {
     RESET_REAPPLY_EXCLUDE_TYPE_UPDATE = 2;
     // Exclude nexus events when reapplying events beyond the reset point.
     RESET_REAPPLY_EXCLUDE_TYPE_NEXUS = 3;
-    reserved 4;
-    reserved "RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST";
+    // Exclude cancel request events when reapplying events beyond the reset point.
+    RESET_REAPPLY_EXCLUDE_TYPE_CANCEL_REQUEST = 4 [deprecated=true];
 }
 
 // Event types to include when reapplying events. Deprecated: applications