Skip to content

Commit

Permalink
Moving retry interval to ApplicationFailure per Yimins request.
Browse files Browse the repository at this point in the history
  • Loading branch information
ast2023 committed Jan 12, 2024
1 parent 59df52a commit 2742103
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
9 changes: 9 additions & 0 deletions temporal/api/failure/v1/message.proto
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,19 @@ option csharp_namespace = "Temporalio.Api.Failure.V1";
import "temporal/api/common/v1/message.proto";
import "temporal/api/enums/v1/workflow.proto";

import "google/protobuf/duration.proto";

message ApplicationFailureInfo {
string type = 1;
bool non_retryable = 2;
temporal.api.common.v1.Payloads details = 3;
// next_retry_delay can be used by the client to override the activity
// retry interval calculated by the retry policy. Retry attempts will
// still be subject to the maximum retries limit and total time limit
// defined by the policy.
// ATTENTION: this value will be ignored if set for failures produced by
// the workflow.
google.protobuf.Duration next_retry_delay = 4;
}

message TimeoutFailureInfo {
Expand Down
5 changes: 0 additions & 5 deletions temporal/api/workflowservice/v1/request_response.proto
Original file line number Diff line number Diff line change
Expand Up @@ -506,11 +506,6 @@ message RespondActivityTaskFailedRequest {
// always be set by SDKs. Workers opting into versioning will also set the `use_versioning`
// field to true. See message docstrings for more.
temporal.api.common.v1.WorkerVersionStamp worker_version = 6;
// next_retry_delay can be used by the client to override the activity
// retry interval calculated by the retry policy. Retry attempts will
// still be subject to the maximum retries limit and total time limit
// defined by the policy.
google.protobuf.Duration next_retry_delay = 7;
}

message RespondActivityTaskFailedResponse {
Expand Down

0 comments on commit 2742103

Please sign in to comment.