Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pgrx, clerk-rs, chrono; support Postgres 17 #38

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Update pgrx, clerk-rs, chrono; support Postgres 17 #38

merged 3 commits into from
Dec 10, 2024

Conversation

theory
Copy link
Contributor

@theory theory commented Dec 6, 2024

No description provided.

@theory theory requested review from ChuckHend and Jayko001 December 6, 2024 22:24
@theory theory self-assigned this Dec 6, 2024
The build error was:

    error: no bin target named `pgrx_embed_clerk_fdw`.

This is a side-effect of pgrx v0.12.x; pgcentralfoundation/pgrx#1888
documents the fix: adding a no-op embed target in
`src/bin/pgrx_embed_clerk_fdw.rs` and setting `lib.crate-type` to:

    crate-type = ["cdylib", "lib"]

Hopefully this funky workaround can be removed in the future.

The test simply ensures that `CREATE EXTENSION` works; the update to
`extension_ci.yml` ensures it passes on all supported Postgres versions.
Copy link

@joshuajerin joshuajerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theory theory merged commit 751322d into main Dec 10, 2024
6 checks passed
@theory theory deleted the upgrades branch December 10, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants