Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol fallback #129

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Symbol fallback #129

merged 2 commits into from
Jan 8, 2024

Conversation

kspeyanski
Copy link
Contributor

@kspeyanski kspeyanski commented Dec 21, 2023

A couple of things here to consider:

  • With version v44 of cldr-* packages, it seems the symbol field has been removed from the currensies.json files, unless it's a different symbol. This breaks scenarios where the symbol and the currency abbreviation are the same (e.g. CHF currency in de-CH lang/locale pair) — thus the added fallback from the first commit:
    image
  • The removal of the symbol field might not be intentional, but rather a regression, since I was not able to find any info on their changelog
  • Adding a test case as the current one with the BGN currency actually have a dedicated symbol.
  • The latests cldr version is 44.1, HOWEVER, they have a failed 44.1.0 deployment of cldr-core, which other packages have already listed as dependency. — thus the version bump
    image

cc, @telerik/kendo-intl-reviewers

@kspeyanski kspeyanski requested a review from a team as a code owner December 21, 2023 13:57
Copy link
Member

@tsvetomir tsvetomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's weird. Let's hope the format doesn't flip-flop too much.

@kspeyanski
Copy link
Contributor Author

@tsvetomir Reserving back to only tackling the bug in this PR, will follow up with a separate one to handle version bumps and tests

@kspeyanski kspeyanski merged commit d2286da into develop Jan 8, 2024
1 check passed
@kspeyanski kspeyanski deleted the symbol-fallback branch January 8, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants