-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new kb article map-kb-customize-marker-colors #2700
Added new kb article map-kb-customize-marker-colors #2700
Conversation
Hello @Tsvetomir-Hr, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
ae487d1
to
61e7714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a similar example for this here:
Both of them have their pros and cons. Yours is simpler, because it does not require knowledge about the SVG icon rendering. However, it requires knowledge of the titles and colors. Instead of hard-coding them, refactor the example, so that:
- The colors are part of the Marker Layer datasource.
- The CSS is generated programmatically, so that it doesn't hard-code the titles.
You can leave the example as a separate KB or move it to the article. If you prefer a KB, link it from the Marker Layer article.
I'm planning to leave the example as a separate KB. Will make the required changes. Thanks. |
Co-authored-by: Dimo Dimov <[email protected]>
Here you are the link to your PR to production: 2719 |
No description provided.