Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new kb article map-kb-customize-marker-colors #2700

Conversation

kendo-bot
Copy link
Collaborator

No description provided.

@kendo-bot kendo-bot requested a review from a team as a code owner January 14, 2025 09:39
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Jan 14, 2025
@Tsvetomir-Hr Tsvetomir-Hr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jan 14, 2025
Copy link
Contributor

Hello @Tsvetomir-Hr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@Tsvetomir-Hr Tsvetomir-Hr force-pushed the new-kb-map-kb-customize-marker-colors-0811f4f4659446da917cbf310881abb5 branch from ae487d1 to 61e7714 Compare January 14, 2025 12:48
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a similar example for this here:

https://www.telerik.com/blazor-ui/documentation/components/map/layers/marker#customizing-marker-appearance

Both of them have their pros and cons. Yours is simpler, because it does not require knowledge about the SVG icon rendering. However, it requires knowledge of the titles and colors. Instead of hard-coding them, refactor the example, so that:

  • The colors are part of the Marker Layer datasource.
  • The CSS is generated programmatically, so that it doesn't hard-code the titles.

You can leave the example as a separate KB or move it to the article. If you prefer a KB, link it from the Marker Layer article.

@Tsvetomir-Hr
Copy link
Contributor

You can leave the example as a separate KB or move it to the article. If you prefer a KB, link it from the Marker Layer article.

I'm planning to leave the example as a separate KB. Will make the required changes. Thanks.

@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team as a code owner January 16, 2025 14:57
@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi January 16, 2025 14:57
@Tsvetomir-Hr Tsvetomir-Hr requested a review from dimodi January 20, 2025 09:15
Co-authored-by: Dimo Dimov <[email protected]>
@Tsvetomir-Hr Tsvetomir-Hr merged commit 56b9e26 into master Jan 22, 2025
1 check passed
Copy link
Contributor

Here you are the link to your PR to production: 2719

@github-actions github-actions bot deleted the new-kb-map-kb-customize-marker-colors-0811f4f4659446da917cbf310881abb5 branch January 22, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-to-production Use this label to get a comment to choose whether to merge the PR to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants