Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Snapshot builds for branches #11

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: Snapshot builds for branches #11

merged 1 commit into from
Feb 26, 2024

Conversation

chrisingenhaag
Copy link
Member

@chrisingenhaag chrisingenhaag commented Feb 26, 2024 •
edited
Loading

  • Make snapshot publishing part of build with an extra step which only runs on feature branches
  • No more additional workflow as head branch is not consistent in workflow triggered action runs
  • use branch name pattern 0.0.0--SNAPSHOT
  • sanitized branch name is done with toLowerCase() as well as replace all / + _ with -

@chrisingenhaag chrisingenhaag self-assigned this Feb 26, 2024
@chrisingenhaag chrisingenhaag force-pushed the feature/easeSnapshotPublishing branch 2 times, most recently from 5bd2083 to 9a6a26d Compare February 26, 2024 14:35
@github-actions GitHub Actions
Copy link

Overall Project 25.69% ❌

There is no coverage information present for the Files changed

@chrisingenhaag chrisingenhaag force-pushed the feature/easeSnapshotPublishing branch from 9a6a26d to 1ceafc2 Compare February 26, 2024 14:51
@github-actions GitHub Actions
Copy link

Overall Project 25.69% ❌

There is no coverage information present for the Files changed

@chrisingenhaag chrisingenhaag force-pushed the feature/easeSnapshotPublishing branch from 1ceafc2 to a209256 Compare February 26, 2024 15:08
@github-actions GitHub Actions
Copy link

Overall Project 25.69% ❌

There is no coverage information present for the Files changed

@chrisingenhaag chrisingenhaag force-pushed the feature/easeSnapshotPublishing branch 2 times, most recently from d463477 to 71e8c09 Compare February 26, 2024 15:18
@github-actions GitHub Actions
Copy link

Overall Project 25.69% ❌

There is no coverage information present for the Files changed

@chrisingenhaag chrisingenhaag force-pushed the feature/easeSnapshotPublishing branch from 71e8c09 to 2fb7f3b Compare February 26, 2024 15:20
@github-actions GitHub Actions
Copy link

Overall Project 25.69% ❌

There is no coverage information present for the Files changed

@chrisingenhaag chrisingenhaag force-pushed the feature/easeSnapshotPublishing branch from 2fb7f3b to 5adce75 Compare February 26, 2024 15:29
@github-actions GitHub Actions
Copy link

Overall Project 25.69% ❌

There is no coverage information present for the Files changed

@chrisingenhaag chrisingenhaag changed the title fix: Move snapshot publish to extra step in build fix: Snapshot builds for branches Feb 26, 2024
@chrisingenhaag chrisingenhaag merged commit 9fc8061 into main Feb 26, 2024
2 checks passed
@chrisingenhaag chrisingenhaag deleted the feature/easeSnapshotPublishing branch February 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th3Shadowbroker Th3Shadowbroker Th3Shadowbroker approved these changes

Assignees

@chrisingenhaag chrisingenhaag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisingenhaag @Th3Shadowbroker