Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include operator details in valid evaluation result #26

Merged

Conversation

ledex
Copy link
Contributor

@ledex ledex commented May 6, 2024

This is needed to improve the filter trace for dropped messages in the UI.

@ledex ledex requested a review from a team as a code owner May 6, 2024 15:11
@ledex ledex requested review from mherwig and julian-spierefka and removed request for a team May 6, 2024 15:11
Copy link

github-actions bot commented May 6, 2024

Overall Project 82.56% 🍏
Files changed 100% 🍏

File Coverage
ComparisonOperatorEnum.java 100% 🍏
ComparisonOperator.java 89.89% 🍏
EvaluationResult.java 71.26% 🍏
LogicOperator.java 60.38% 🍏

Copy link
Member

@Th3Shadowbroker Th3Shadowbroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@ledex ledex merged commit 745cdf5 into main May 10, 2024
5 checks passed
@ledex ledex deleted the feature/include-operator-details-in-valid-evaluation-result branch May 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants