Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/store last measure #1670

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Task/store last measure #1670

wants to merge 22 commits into from

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Nov 19, 2024 •
edited
Loading

#1669

@AlvaroVega AlvaroVega marked this pull request as ready for review November 28, 2024 14:28
fgalan
fgalan reviewed Jan 8, 2025
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
@fgalan
Copy link
Member

fgalan commented Jan 8, 2025

Similar comment to the one at #1677 (comment)

I'd suggest to make the last measure option to use the same approach that with another on/off features (eg. timestamp), that can be set at IOTA instance / group / device level, with the same precedence rules.

@fgalan
Copy link
Member

fgalan commented Jan 8, 2025

Should this PR include tests cases regarding the new feature?

fgalan
fgalan reviewed Jan 8, 2025
View reviewed changes
doc/admin.md Outdated
Comment on lines 424 to 425
If this flag is activated, last measure arrived to Device IoTAgent without be processed will be stored in Device under
lastMeasure field with in timestamp. This flag is disabled by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an example on how the measure is stored would be helpful. By the "will be stored in Device under
lastMeasure field with in timestamp" it is not fully clear (e.g. is a sub-JSON object used for that)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 1f6f3f4

fgalan
fgalan reviewed Jan 8, 2025
View reviewed changes
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
@AlvaroVega
Copy link
Member Author

Similar comment to the one at #1677 (comment)

I'd suggest to make the last measure option to use the same approach that with another on/off features (eg. timestamp), that can be set at IOTA instance / group / device level, with the same precedence rules.

Done in df26df1

@AlvaroVega
Copy link
Member Author

Should this PR include tests cases regarding the new feature?

Tests addresed in this other PR telefonicaid/iotagent-json#848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan