Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/upgrade mongoose 8 #352

Merged
merged 13 commits into from
Dec 16, 2024
Merged

Task/upgrade mongoose 8 #352

merged 13 commits into from
Dec 16, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Dec 4, 2024

#351

All works needed to upgrade from mongoose 5 to mongoose 8, including callbacks, connection, tests

  • Update component
  • Remove CI for nodejs v14 (mongoose 7 needs nodejs 16)

@coveralls
Copy link

coveralls commented Dec 10, 2024

Pull Request Test Coverage Report for Build 12347631572

Details

  • 60 of 94 (63.83%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.8%) to 74.447%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/services/protocols.js 6 8 75.0%
lib/services/configurationData.js 10 16 62.5%
lib/services/protocolData.js 16 22 72.73%
lib/model/dbConn.js 26 46 56.52%
Files with Coverage Reduction New Missed Lines %
lib/services/protocolData.js 1 83.13%
lib/model/dbConn.js 1 54.21%
Totals Coverage Status
Change from base Build 12155122315: -1.8%
Covered Lines: 541
Relevant Lines: 688

💛 - Coveralls

@AlvaroVega AlvaroVega changed the title [WIP] Task/upgrade mongoose 8 Task/upgrade mongoose 8 Dec 11, 2024
@AlvaroVega AlvaroVega marked this pull request as ready for review December 12, 2024 09:18
@AlvaroVega AlvaroVega requested a review from fgalan December 13, 2024 07:02
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
AlvaroVega and others added 2 commits December 16, 2024 08:06
Co-authored-by: Fermín Galán Márquez <[email protected]>
Co-authored-by: Fermín Galán Márquez <[email protected]>
@GregorioBlazquez GregorioBlazquez merged commit c0d53fc into master Dec 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants