Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbConn.js #239

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Update dbConn.js #239

merged 1 commit into from
Mar 9, 2021

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Mar 9, 2021

fix typo introduced by 5bdaf91
No CNR update is needed

possible fix for #236

@AlvaroVega AlvaroVega requested a review from fgalan March 9, 2021 09:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 635306158

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.171%

Totals Coverage Status
Change from base Build 623846852: 0.0%
Covered Lines: 500
Relevant Lines: 617

💛 - Coveralls

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 3d57405 into master Mar 9, 2021
@fgalan fgalan deleted the AlvaroVega-patch-1 branch March 9, 2021 10:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 635306158

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.171%

Totals Coverage Status
Change from base Build 623846852: 0.0%
Covered Lines: 500
Relevant Lines: 617

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 635306158

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.171%

Totals Coverage Status
Change from base Build 623846852: 0.0%
Covered Lines: 500
Relevant Lines: 617

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants