Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/srv subsrv logs #212

Merged
merged 9 commits into from
Sep 15, 2020
Merged

Fix/srv subsrv logs #212

merged 9 commits into from
Sep 15, 2020

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Sep 15, 2020 •
edited
Loading

related #211

@AlvaroVega AlvaroVega requested a review from fgalan September 15, 2020 09:31
fgalan
fgalan reviewed Sep 15, 2020
View reviewed changes
CHANGES_NEXT_RELEASE
Comment on lines +1 to +2
- Fix: set service subservice in logs of redirector and configurations
- Fix: set new trans and corr or use it if provided in logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#211 should be mentioned in one of these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about 211 will be fixed with this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I missinterpret the "related #211" in this PR 👍

NTC

@AlvaroVega AlvaroVega mentioned this pull request Sep 15, 2020
Open
fgalan
fgalan approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit c5d8d8a into master Sep 15, 2020
@fgalan fgalan deleted the fix/srv_subsrv_logs branch September 15, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlvaroVega @fgalan