-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Debian 12 #4417
Migration to Debian 12 #4417
Conversation
At commit b65186d, valgrind pass seems ok:
A full pass has not been done, given it takes a long time, it will be done by GitActions once this PR gets merged. |
The actual results (pretty low) is not relevant (this is due we are no relying in unit test too much since MongoDB driver changed time ago in Orion 3.0.0). What is relevant is that the coverage tooling works. |
# Comparison is done based in filename, skipping the path (see https://stackdiary.com/tutorials/bash-get-filename-from-path/) | ||
if [ "${testcase##*/}" == "${DISABLED[$dIx]##*/}" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not actually related with this PR, but found while I was investigating make coverage issues.
NTC (informative)
At commit 2d870f7 first run is with preexisting Debian 11 image Let's build now the new Debian 12 based image in dockerhub and see how it goes... |
After some problem with dockerhub, the new image was finally build from commit 2d870f7 in this branch: Launching new pass of tests... |
Fails in cases/1705_csub_cache_objects/csub_cache_objects_errors.test due to curl CLI has changed: Debian 11:
Debian 12:
Thus, it seem curl has changed its behaviour among versions... I have posted to SOF about this: https://stackoverflow.com/questions/77045755/avoid-curl-to-check-for-malformed-urls |
@fisuda, several .md files in the English version have been modified in this PR. I have partially modified some Japanese .md files to align, but only partially (mainly numeric information). It would be great if you could have a look and complete this synchronization work in a PR using hardening/debian12-migration (this PR's branch) as base branch, please. With regards to the "Ubuntu 20.04 TLS" sections, it would be great if you could check if the procedure described there is still working after the changes of this PR but that could be of course accomplished in a separate PR (related with what discussed in this other PR. Thanks in advance! |
I sent the PR #4419. In the current version (before merging this PR), it seems that the Orion can be built with mongo driver 1.24.3 on Ubuntu 20.04. As of now, Ubuntu LTS (Long Term Support) version is 22.04. So I'm trying to build Orion on Ubuntu 22.04. But I enounted same error as building on debian 12. Because It seems that the base distribution of Ubuntu 22.04.3 LTS is debian 12. Atfer this PR is merged, I'd like to try to build Orion again. And I will update the "Ubuntu 20.04 LTS" sections to the "Ubuntu 22.04 LTS" sections.
Thanks |
(JP) ADD doc about Debian 12 (#4417)
Sounds nice! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docker build -t prueba --build-arg GIT_REV_ORION=hardening/debian12-migration .
) - 224ace3(*) Up to this point, regression in this PR commits is done using preexisting Debian 11 based CI image