_Fixed #857 #858 #900 #902 + glitches on #860 fix #12
Conversation
| <div id="nb-search-results" class="flex1 padding8" class="padding8" | ||
| ng-if="nbSearchResults"> | ||
| Résultats: {{ nbSearchResults }} | ||
| </div> | ||
| <filesearch></filesearch> | ||
| <button class="btn btn-default" type="button" > | ||
| <span class="padding8 glyphicon glyphicon-cloud-upload" aria-hidden="true"></span> | ||
| <button class="btn btn-default" ng-controller="FilesListController as fileCtrl" ng-click="fileCtrl.showUploadFileModal()" type="button" > |
There was a problem hiding this comment.
showUploadFileModal n'est pas implémenté
| </button> | ||
| <button class="btn btn-default" type="button" > | ||
| <button class="btn btn-default" ng-controller="FilesListController as fileCtrl" ng-click="fileCtrl.createNewFolder()" type="button" > |
| </div> | ||
| <div class="modal-footer"> | ||
| <button type="button" ng-click="newFolderModalCtrl.closeModal()" class="btn btn-default">Annuler</button> | ||
| <button type="button" ng-click="newFolderModalCtrl.closeUploadFileModal(newFolderModalCtrl.file, newFolderModalCtrl.permissions, newFolderModalCtrl.licence)" class="btn btn-primary">Créer</button> |
There was a problem hiding this comment.
closeUploadFileModal n'est pas implémenté
| @@ -405,6 +401,7 @@ body.modal-open { | |||
| float: none; | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Je profite de cet ajout de ligne pour signaler le changement de droits au niveau de ce fichier, les deux semblent inappropriés
| @@ -11,7 +11,7 @@ <h4 class="modal-title">Supprimer?</h4> | |||
| </div> | |||
| <div class="modal-footer"> | |||
| <button type="button" ng-click="modalCtrl.close('Delete')" class="btn btn-default" data-dismiss="modal">Supprimer pour toujours</button> | |||
| <button type="button" ng-click="modalCtrl.close()" class="btn btn-primary" data-dismiss="modal">Annuler</button> | |||
| <button type="button" ng-click="modalCtrl.closeModal()" class="btn btn-primary" data-dismiss="modal">Annuler</button> | |||
There was a problem hiding this comment.
Pourquoi changer les close en closeModal ?
| ng-click="isDetailsPaneOpened = !isDetailsPaneOpened" | ||
| ng-class="{ active: isDetailsPaneOpened }"> | ||
| ng-click="isDetailsPaneOpened = !isDetailsPaneOpened" | ||
| ng-class="{ active: isDetailsPaneOpened }"> |
There was a problem hiding this comment.
Je profite de ce changement d'indentation pour signaler le changement de droits au niveau de ce fichier, les deux semblent inappropriés
| controller: function($scope, files, close) { | ||
| var vm = this; | ||
|
|
||
| vm.folderName = 'Indiquer un nom pour '; |
| currentPath = crumbsArray.slice(1, crumbsArray.length).join('/'); | ||
| $rootScope.$broadcast('openAbsoluteFolder', '/' + currentPath); | ||
| ngToast.create('Répertoire créé avec succès.'); | ||
| jQuery(".modal-backdrop").remove(); |
There was a problem hiding this comment.
Si cette ligne et la suivante sont en dehors du if on peut sûrement se passer du closeModal
| @@ -1,168 +1,308 @@ | |||
| (function() { | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Pourquoi réindenter tout le fichier ?
| vm.folderName = 'Indiquer un nom pour '; | ||
|
|
||
|
|
||
| vm.closeModal = function() { |
There was a problem hiding this comment.
Les modales se ferment déjà avec close() normalement
| }; | ||
|
|
||
| vm.closeUploadFileModal = function(result) { | ||
| // Current service code doesn't handle licence/Permissions |
There was a problem hiding this comment.
Le paramètre license semble pris en compte par cumulus :
En post : https://github.com/telabotanica/cumulus/blob/master/CumulusService.php#L802
En put : https://github.com/telabotanica/cumulus/blob/master/CumulusService.php#L584
Et permissions est juste à coté. Est-ce qu'il y a un bug avec ces paramètres ?
|
|
||
|
|
||
| vm.uploadFile = function() { | ||
| FilesListService.uploadFile(); |
There was a problem hiding this comment.
uploadFile n'est pas implémenté, est-ce plutôt uploadFiles ?
Please delete previous PR (a few edited files containing only new EOF + spaces were polluting it). This one replaces it.