-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build added #38
base: main
Are you sure you want to change the base?
Conversation
Config.json file missing from this pull request due to user error . I will do that when I get back to the keyboard. |
Awesome - thank you. |
I wrote a small md which mentions if you start running it with docker run it's attaches the cli in your terminal so it's rather convenient for now. If someone wraps it inside a tmux / screen session or run it from portainer or yacht it can be more user friendly to attach detach the docker cli session I realise it now I should have write it inside readme. If I don't forget I will merge the run.md and readme.md in this PR |
I will wait for your additions :) Can ping you here in few days if you forgot about it. |
Well, I have moved files to root of the repo to make it easier for anyone. Hope you find it useful. |
One more thing when i tried to rebase image to from node:17-bullseyes-slim to node:18-buster-slim on startup Parcel failed to build The site |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
do you have an error message on that? |
Now, files are duplicated :) And maybe instead of modifying / providing a separate docker config file, you can adjust the server.js, to check if there are env vars set. If not, then a config.js has to be there. |
Fair enough . I was thinking more like just keeping config.js with const = env || default . Would that be more user friendly ? |
So I made some changes, which can cause problem for non-docker users. Which I just realised now. Thanks for the quick feedback and communication 😄 |
Greetings,
I created a simple docker version, which was double staged for anyone whom using their own registry or want to move docker image after build. API_ID and API_HASH loaded from env so that it can be called easily. There is a room for improvement, however is does the job. Of course because of the native lib dependencies (which could be integrated later to make it cross-platform) it's only works on x86_64