Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging of applied adjust rules #2230

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add logging of applied adjust rules #2230

merged 1 commit into from
Oct 4, 2023

Conversation

happz
Copy link
Collaborator

@happz happz commented Jul 28, 2023

No description provided.

@happz happz added the code | logging Changes related to debug logging label Jul 28, 2023
@happz happz added this to the 1.27 milestone Jul 28, 2023
@happz
Copy link
Collaborator Author

happz commented Jul 28, 2023

Blocked by teemtee/fmf#197

@happz
Copy link
Collaborator Author

happz commented Jul 28, 2023

2023-07-28_13-56

@psss psss added the status | blocked The merging of PR is blocked on some other issue label Aug 11, 2023
psss
psss reviewed Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and very useful! We need to wait though until the fmf change is merged and released.

@happz happz force-pushed the format-value branch 4 times, most recently from 1bf72a9 to 69f3d57 Compare August 21, 2023 06:30
@thrix thrix modified the milestones: 1.27, 1.28 Aug 22, 2023
@thrix
Copy link
Collaborator

thrix commented Aug 22, 2023

Moved to 1.28, as we need a fmf update, and it will take > a wekk

@happz happz force-pushed the format-value branch 3 times, most recently from b6f9245 to 6dd8611 Compare September 4, 2023 16:41
Base automatically changed from format-value to main September 5, 2023 12:55
@thrix
Copy link
Collaborator

thrix commented Sep 18, 2023

Looks nice and very useful! We need to wait though until the fmf change is merged and released.

@psss seems it is waiting now on you :)

thrix
thrix previously requested changes Sep 18, 2023
View reviewed changes
tmt/base.py Outdated Show resolved Hide resolved
@psss
Copy link
Collaborator

psss commented Sep 20, 2023

Looks nice and very useful! We need to wait though until the fmf change is merged and released.

@psss seems it is waiting now on you :)

The plan is to release the fresh fmf this week so that this one is unblocked.

@psss
Copy link
Collaborator

psss commented Oct 3, 2023

/packit test

@psss
Copy link
Collaborator

psss commented Oct 3, 2023

/packit build

@psss
Copy link
Collaborator

psss commented Oct 3, 2023

Hm, seems that fedora-39 jobs will be red until the distro is released (planned for Oct 17). What to do? Enable the fmf copr repo for f39 jobs?

@psss psss requested a review from thrix October 3, 2023 10:54
@psss psss self-assigned this Oct 4, 2023
@psss psss removed the status | blocked The merging of PR is blocked on some other issue label Oct 4, 2023
@psss psss dismissed thrix’s stale review October 4, 2023 11:40

Should be addressed.

@psss psss merged commit 38ce4a8 into main Oct 4, 2023
16 checks passed
@psss psss deleted the adjust-rule-logging branch October 4, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@janhavlin janhavlin janhavlin approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees

@psss psss

Labels
code | logging Changes related to debug logging
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
5 participants
@happz @thrix @psss @janhavlin @therazix