Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the filter() documentation slightly #235

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

The-Mule
Copy link

@The-Mule The-Mule commented May 3, 2024

People tend to try using parentheses in their filter expressions for obvious reasons. But it is not possible. I feel like this should be mentioned in the documentation. In fact, with DNF you never need parentheses to express any expression and I think this fact also needs to be noted there.

fmf/utils.py Outdated Show resolved Hide resolved
@lukaszachy lukaszachy added this to the 1.4 milestone May 10, 2024
@lukaszachy lukaszachy requested a review from psss May 10, 2024 13:56
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs. Added a couple of questions and suggestions.

fmf/utils.py Outdated Show resolved Hide resolved
fmf/utils.py Outdated Show resolved Hide resolved
fmf/utils.py Outdated Show resolved Hide resolved
fmf/utils.py Outdated Show resolved Hide resolved
@psss psss added the docs label May 13, 2024
@psss psss changed the title Extend filter documentation slightly Extend the filter() documentation slightly May 13, 2024
@lukaszachy lukaszachy self-requested a review May 13, 2024 15:34
@lukaszachy
Copy link
Collaborator

Depends on #220, we have to adjust docs once that is merged.

@The-Mule
Copy link
Author

The-Mule commented Jun 5, 2024

Thanks for the fix, Petre, let me also rebase it now.

@The-Mule The-Mule requested a review from psss June 5, 2024 08:39
@psss
Copy link
Collaborator

psss commented Jun 5, 2024

Thanks for the rebase, going to squash the changes now.

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs improvement!

fmf/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@lukaszachy lukaszachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, but no point in blocking on that

People tend to try using parentheses in their filter expressions
for obvious reasons. But it is not possible. I feel like this
should be mentioned in the documentation. In fact, with DNF you
never need parentheses to express any expression and I think this
fact also needs to be noted there.

Signed-off-by: Ondrej Moris <[email protected]>
Co-authored-by: Petr Šplíchal <[email protected]>
@psss psss merged commit dcab598 into teemtee:main Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants