Allow case-insensitive matching of context dimension values #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszachy
approved these changes
Jul 27, 2023
therazix
force-pushed
the
case-sensitivity
branch
from
5c67b0f
to
848a918
Compare
|
Somehow I missed that child nodes were not adjusted. This should be fixed in 99f608b. |
psss
force-pushed
the
case-sensitivity
branch
from
99f608b
to
f6b5fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching of context dimension values can now be case-insensitive by calling
fmf.Tree.adjust()with thecase_sensitive=Falseparameter. The default behavior remains case-sensitive.I have also updated the documentation about the default behavior and added some tests.
Resolves: #186